-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sbdi-gtdb R09-RS220 #765
Conversation
|
Uff, failing tests are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Easiest is perhaps to comment out that test for the moment? I can do that in this PR if you want to, then try to find urls for the files in another PR. |
Easiest would be if I bypass tests and just merge it. The fix for the links could come in a follow-up PR. Is that ok with you? |
Go ahead! |
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).The latest release of Sativa vetted GTDB added.